Details

Reviewers

laysrodrigues
tcanabrava
patrickelectric

Commits

R232:3c7ea1d4cc3a: New AtCore::setTemperatureTimerInteravl to expose temperature timer changes to…
R232:1b55acc99c6c: New AtCorePrivate::sdPrintProgressTimer used for sd print checks
R232:035bb2062502: Add options to set Temperature Timer
R232:479426da9bb9: Add option to adjust temperature check interval to timeline dock

Summary

New slot AtCore::setTemperatureTimerInterval (0 = disabled)
New AtCore::temperatureTimerIntervalChanged signal
Add option to temperature timeline on the testgui

Test Plan

Exposure method on testGui

Diff Detail

Repository

R232 AtCore

Branch

setTempInterval

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 5997
Build 6015: arc lint + arc unit

rizzitello requested review of this revision.Dec 12 2018, 2:21 AM

rizzitello created this revision.

Harbormaster completed remote builds in B5942: Diff 47410.Dec 12 2018, 2:21 AM

rizzitello edited the summary of this revision. (Show Details)Dec 12 2018, 2:23 AM

rizzitello edited the test plan for this revision. (Show Details)

rizzitello added reviewers: laysrodrigues, tcanabrava, patrickelectric.

rizzitello added a project: Atelier: AtCore.

rizzitello added a subscriber: Atelier: AtCore.

New AtCorePrivate::sdPrintProgressTimer used for sd print checks
Add option to setTemperatureTimerInterval
Add option to adjust temperature check interval to timeline dock

Harbormaster completed remote builds in B5943: Diff 47412.Dec 12 2018, 2:41 AM

tcanabrava requested changes to this revision.Dec 12 2018, 12:18 PM

tcanabrava added inline comments.

src/core/atcore.cpp
319–335	why not using the QTimer as not a pointer? this simplify things: no need to deelete / recreate it instead of connecting / disconnect you could just connect once and stop it when not needed anymore.
324	d->temperatureTimer->deleteLater();

This revision now requires changes to proceed.Dec 12 2018, 12:18 PM

Tomaz suggestions, slight cleanup

Harbormaster completed remote builds in B5958: Diff 47445.Dec 12 2018, 1:26 PM

rizzitello marked 2 inline comments as done.Dec 12 2018, 1:27 PM

rebase
add Q_PROPERTY for temperature Timer methods

Harbormaster completed remote builds in B5964: Diff 47455.Dec 12 2018, 1:52 PM

tcanabrava accepted this revision.Dec 12 2018, 2:02 PM

This revision is now accepted and ready to land.Dec 12 2018, 2:02 PM

Fix commit order

Harbormaster completed remote builds in B5965: Diff 47456.Dec 12 2018, 2:21 PM

Rebase

Harbormaster completed remote builds in B5984: Diff 47509.Dec 13 2018, 12:43 PM

laysrodrigues accepted this revision.Dec 13 2018, 4:42 PM

patrickelectric accepted this revision.Dec 13 2018, 4:46 PM

rebase

Harbormaster completed remote builds in B5997: Diff 47530.Dec 13 2018, 5:02 PM

rizzitello closed this revision.Dec 13 2018, 5:03 PM

			Path	Packages
M			src/core/atcore.h (20 lines)
M			src/core/atcore.cpp (41 lines)
M			testclient/mainwindow.cpp (30 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	47410	3594b38		Dec 12 2018, 2:21 AM	★	★
Diff 2	47412	3594b38	- New AtCorePrivate::sdPrintProgressTimer used for sd print checks	Dec 12 2018, 2:41 AM	★	★
Diff 3	47445	3594b38	- Tomaz suggestions, slight cleanup	Dec 12 2018, 1:26 PM	★	★
Diff 4	47455	70ab419	- rebase	Dec 12 2018, 1:52 PM	★	★
Diff 5	47456	70ab419	- Fix commit order	Dec 12 2018, 2:21 PM	★	★
Diff 6	47509	f363a45	- Rebase	Dec 13 2018, 12:43 PM	★	★
Diff 7	47530	88aafec	- rebase	Dec 13 2018, 5:02 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
479426da9bb9	3f5866f51926	3c7ea1d4cc3a	Chris Rizzitello	Add option to adjust temperature check interval to timeline dock (Show More…)	Dec 12 2018, 2:04 AM
3c7ea1d4cc3a	e62e476327d8	1b55acc99c6c	Chris Rizzitello	New AtCore::setTemperatureTimerInteravl to expose temperature timer changes to… (Show More…)	Dec 12 2018, 12:58 PM
1b55acc99c6c	7e4ec99e9f56	88aafecd13bb	Chris Rizzitello	New AtCorePrivate::sdPrintProgressTimer used for sd print checks (Show More…)	Dec 12 2018, 2:36 AM

Add options to set Temperature Timer
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 47530

src/core/atcore.h

src/core/atcore.cpp

testclient/mainwindow.cpp

Add options to set Temperature TimerClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 47530

src/core/atcore.h

src/core/atcore.cpp

testclient/mainwindow.cpp

Add options to set Temperature Timer
ClosedPublic
Actions

Revision Contents
Changeset List