[kateproject] Gracefully exit when analyzer is not finished
ClosedPublic

Authored by anthonyfieroni on Dec 11 2018, 1:35 PM.

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
anthonyfieroni created this revision.Dec 11 2018, 1:35 PM
Restricted Application added a project: Kate. · View Herald TranscriptDec 11 2018, 1:35 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
anthonyfieroni requested review of this revision.Dec 11 2018, 1:35 PM

Hmm, I don't think you can just delete the QProcess, isn't there the need to at least terminate it first and wait for finished?

cullmann requested changes to this revision.Dec 11 2018, 2:15 PM
This revision now requires changes to proceed.Dec 11 2018, 2:15 PM
cullmann accepted this revision.Dec 11 2018, 2:49 PM

Ok, then I think this can go in.

This revision is now accepted and ready to land.Dec 11 2018, 2:49 PM
This revision was automatically updated to reflect the committed changes.

Not an issue but for the future: your initial summary for the review request is non-existent :) could you in future elaborate? E.g.: did you observe memleaks? Did it crash? Does perf or valgrind proof this? Etc... :)

It crashes, you can see backtrace, start long-running analysis and close Kate before it finish.