Differential D17495

[KMessageBox] Fix minimum dialog size when details are requested
ClosedPublic
Actions

Authored by cfeck on Dec 10 2018, 10:41 PM.

Details

Reviewers
ngraham
elvisangelaccio
dhaumann
Commits
R236:032c783b990e: [KMessageBox] Fix minimum dialog size when details are requested
Summary

QLabel with wordWrap enabled still needs the minimumSize workaround, which conflicts with the dialog setting its own minimumSize.

BUG: 401466

Test Plan

.bin/kmessageboxtest 12: When clicking the "Details >>" button, the dialog window now resizes to show the details.

Diff Detail

Repository
R236 KWidgetsAddons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cfeck created this revision.Dec 10 2018, 10:41 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 10 2018, 10:41 PM
Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. · View Herald Transcript
cfeck requested review of this revision.Dec 10 2018, 10:41 PM
cfeck edited the test plan for this revision. (Show Details)Dec 10 2018, 10:54 PM
cfeck added reviewers: ngraham, elvisangelaccio.
dhaumann accepted this revision.Dec 11 2018, 7:23 AM
This revision is now accepted and ready to land.Dec 11 2018, 7:23 AM
ngraham accepted this revision.Dec 11 2018, 3:06 PM
Closed by commit R236:032c783b990e: [KMessageBox] Fix minimum dialog size when details are requested (authored by cfeck). · Explain WhyDec 18 2018, 9:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/kmessagebox.cpp (7 lines)

Diff 47800

View Options

src/kmessagebox.cpp

Loading...