This is a work in progress implementation of T7927
Details
Details
- Reviewers
- None
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
- This needs screenshots. :)
- Don't you think it's premature to submit code before we've settled on what it is we actually want? I don't see any consensus in T7927. Personally I am not at all sold on the idea of presenting users with ten font rendering options and expecting them to be able to choose their favorite. The differences between most of them are minuscule and seem all but impossible for someone who's not a font nerd to distinguish. The idea of visual previews seems sound, but I think we would need to limit them to choices that lay people actually have a chance of understanding and distinguishing between.
Comment Actions
Please consider this work in progress. There are no reviewers. Is there another way to mark this as "not ready"?
| kcms/fonts/fonts.cpp | ||
|---|---|---|
| 505 | This doesn't work on current kde-neon/dev/unstable The Qt documentation http://doc.qt.io/qt-5/qqmlengine.html#addImageProvider says:
At this point however qml files are already loaded. | |
Comment Actions
Is there another way to mark this as "not ready"?
We typically write "WIP:" or "RFC:" in the title, you can also set the review status to "Changes planned"
| kcms/fonts/fonts.cpp | ||
|---|---|---|
| 505 | What prevents us moving this to the constructor? | |
| kcms/fonts/freetype-renderer.cpp | ||
|---|---|---|
| 342–345 | sub-pixel rendered glyphs have unusual color haze | |