Upload new screenshots in the documentation and uncomment a section
AbandonedPublic

Authored by ognarb on Dec 10 2018, 3:27 PM.

Details

Summary

New screenshots that reflect current version of system settings. I also uncommented a section in the splash screen.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ognarb created this revision.Dec 10 2018, 3:27 PM
Restricted Application added projects: Plasma, Documentation. · View Herald TranscriptDec 10 2018, 3:27 PM
Restricted Application added subscribers: kde-doc-english, plasma-devel. · View Herald Transcript
ognarb requested review of this revision.Dec 10 2018, 3:27 PM
davidedmundson accepted this revision.Dec 11 2018, 10:37 AM
This revision is now accepted and ready to land.Dec 11 2018, 10:37 AM
yurchor requested changes to this revision.Dec 11 2018, 11:28 AM
yurchor added a subscriber: yurchor.
yurchor added inline comments.
doc/kcontrol/splashscreen/index.docbook
103

To keep the result valid this line should be removed as well.

This revision now requires changes to proceed.Dec 11 2018, 11:28 AM
ognarb added inline comments.Dec 11 2018, 11:56 AM
doc/kcontrol/splashscreen/index.docbook
103

Look line 78, I just moved the beginning of the comment.

yurchor accepted this revision.Dec 11 2018, 11:57 AM

Oops... Sorry.

This revision is now accepted and ready to land.Dec 11 2018, 11:57 AM

Oops... Sorry.

No problems :) Thanks for the review.

This revision was automatically updated to reflect the committed changes.
broulik reopened this revision.Dec 11 2018, 1:21 PM
broulik added a subscriber: broulik.

Breaks build of plasma-desktoop:

index.docbook:104: parser error : Opening and ending tag mismatch: variablelist line 53 and article
</article>
          ^
index.docbook:118: parser error : Premature end of data in tag article line 7

^
kf5.kdoctools: Error: `xmllint --noout` outputted text
This revision is now accepted and ready to land.Dec 11 2018, 1:21 PM
broulik requested changes to this revision.Dec 11 2018, 1:21 PM
This revision now requires changes to proceed.Dec 11 2018, 1:21 PM

Fixed. Thanks. Sorry for been negligent when reviewing this.

Breaks build of plasma-desktoop:

index.docbook:104: parser error : Opening and ending tag mismatch: variablelist line 53 and article
</article>
          ^
index.docbook:118: parser error : Premature end of data in tag article line 7

^
kf5.kdoctools: Error: `xmllint --noout` outputted text

Sorry for the trouble. For future reference, do you know a way how to only compile the doc, because it's a bit difficult to build the entire plasma project and all dependencies, only to test if the documentation compile. Otherwise, next time I will let my machine compile :)

Breaks build of plasma-desktoop:

index.docbook:104: parser error : Opening and ending tag mismatch: variablelist line 53 and article
</article>
          ^
index.docbook:118: parser error : Premature end of data in tag article line 7

^
kf5.kdoctools: Error: `xmllint --noout` outputted text

Sorry for the trouble. For future reference, do you know a way how to only compile the doc, because it's a bit difficult to build the entire plasma project and all dependencies, only to test if the documentation compile. Otherwise, next time I will let my machine compile :)

Just

checkXML5 index.docbook

would be enough.

ognarb abandoned this revision.Dec 19 2018, 2:05 PM