Differential D17479

Fix build without phonon
ClosedPublic
Actions

Authored by heikobecker on Dec 10 2018, 3:15 PM.

Details

Reviewers
sitter
Commits
R305:78a1dcc794f5: Fix build without Phonon
Summary

f6d55baf5aa88eaab6b2f96c025064f081d13cea replaced ${PHONON_LIBS} with
Phonon's imported target. This breaks in the case when Phonon isn't
found or disabled via -DCMAKE_DISABLE_FIND_PACKAGES_Phonon4Qt5=TRUE
because the imported target isn't known. It worked previously because
was ${PHONON_LIBS} just empty when Phonon wasn't available.

Test Plan

Building without phonon works now and and it still builds
with phonon available and successfully links to it.

Diff Detail

Repository
R305 KNotifyConfig
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
heikobecker created this revision.Dec 10 2018, 3:15 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 10 2018, 3:15 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
heikobecker requested review of this revision.Dec 10 2018, 3:15 PM
sitter accepted this revision.Dec 10 2018, 3:32 PM

Oh la la, I didn't even realize phonon was optional. New code is much better.

This revision is now accepted and ready to land.Dec 10 2018, 3:32 PM
Closed by commit R305:78a1dcc794f5: Fix build without Phonon (authored by heikobecker). · Explain WhyDec 10 2018, 3:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/CMakeLists.txt (8 lines)

Diff 47288

View Options

src/CMakeLists.txt

Loading...