always print status info on vlc finding (even when not found)
ClosedPublic

Authored by sitter on Dec 10 2018, 11:28 AM.

Details

Summary

this is arguably more valuable information when LIBVLC_FOUND is falsy
as it aids diagnostics, so only printing it when vlc was actually found
is rather pointless. to not change behavior to much we'll now print status
in both scenarios instead.

Test Plan

prints all the time

Diff Detail

Repository
R489 Phonon: VLC backend
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter requested review of this revision.Dec 10 2018, 11:28 AM
sitter created this revision.
bshah accepted this revision.Dec 10 2018, 11:30 AM
This revision is now accepted and ready to land.Dec 10 2018, 11:30 AM
This revision was automatically updated to reflect the committed changes.
adridg added a subscriber: adridg.Dec 10 2018, 11:32 AM
adridg added inline comments.
cmake/FindLIBVLC.cmake
3

Should probably be 2011-2012, 2018, but that's copyright-notice-wrangling.

102

Since you're changing this anyway, how about chaging the endif to modern style as well?