Differential D17460

fixups for `extern` and `pragma`
ClosedPublic
Actions

Authored by aG0aep6G on Dec 9 2018, 8:21 PM.

Details

Reviewers
dhaumann
Commits
R216:dc79692de359: fixups for `extern` and `pragma`
Summary

add "Objective-C" linkage type

fix extern(C++) and add support for extern(C++, ...)

fix pragma(foo, ...)

add more well-known pragma types

Diff Detail

Repository
R216 Syntax Highlighting
Branch
extern-and-pragma
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6618
Build 6636: arc lint + arc unit
aG0aep6G created this revision.Dec 9 2018, 8:21 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptDec 9 2018, 8:21 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
aG0aep6G requested review of this revision.Dec 9 2018, 8:21 PM
dhaumann added a subscriber: dhaumann.Dec 10 2018, 7:34 PM

Could you also extend the unit test in autotest/input/highlight.d?

See e.g.: https://github.com/KDE/syntax-highlighting/commit/66367f8e636623a2dbb8ee6add9c7f36683605a2

aG0aep6G updated this revision to Diff 47369.Dec 11 2018, 5:26 PM
  • update test files
  • fix version = foo;
  • add some more test lines
aG0aep6G added a comment.Dec 11 2018, 5:27 PM
In D17460#374942, @dhaumann wrote:

Could you also extend the unit test in autotest/input/highlight.d?

Done. I also noticed that my last patch broke version = X; so I fixed that, too.

dhaumann accepted this revision.Dec 12 2018, 12:13 AM

Thanks, good patch again.

Note to self: Before we commit, we need to increase the version number in the language xml element.

This revision is now accepted and ready to land.Dec 12 2018, 12:13 AM
dhaumann added a comment.Jan 3 2019, 7:54 PM

@aG0aep6G I just tried to commit this, but it does not work due to the following issue:

XSDError in data/syntax/d.xml, at line 613, column 60: Element context is missing required attribute lineEndContext.

Can you provide an updated patch to fix this? Or at least tell me what lineEndContext should be used here?

aG0aep6G updated this revision to Diff 48634.Jan 3 2019, 8:03 PM
  • add missing lineEndContext attribute
aG0aep6G added a comment.Jan 3 2019, 8:04 PM
In D17460#386002, @dhaumann wrote:

Can you provide an updated patch to fix this? Or at least tell me what lineEndContext should be used here?

Fixed, I hope.

Closed by commit R216:dc79692de359: fixups for `extern` and `pragma` (authored by dhaumann). · Explain WhyJan 3 2019, 8:08 PM
This revision was automatically updated to reflect the committed changes.

Showing Only Differences

This revision modifies 3 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

PathPackages
Mdata/syntax/d.xml (58 lines)

Diff 48634

View Options

data/syntax/d.xml

Loading...