Add help button to KCMs where it was missing
ClosedPublic

Authored by davidedmundson on Dec 9 2018, 6:27 PM.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Dec 9 2018, 6:27 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 9 2018, 6:27 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 9 2018, 6:27 PM
ngraham accepted this revision.Dec 9 2018, 7:49 PM
This revision is now accepted and ready to land.Dec 9 2018, 7:49 PM

You beat me to it :( I think one can just remove the buttons meddling, the default is Help | Defaults | Apply as far as I can tell.

This revision was automatically updated to reflect the committed changes.

I think one can just remove the buttons meddling, the default is Help | Defaults | Apply as far as I can tell.

Then why was launch wrong?

Then why was launch wrong?

It does setButtons(Apply | Default); in the C++ part

Then why was launch wrong?

It does setButtons(Apply | Default); in the C++ part

Then my patch was kinda crappy :/
I'll tidy it up.

abetts added a subscriber: abetts.Dec 10 2018, 3:45 PM

Thanks Dave!