BrightScript: Remove unused keyword list 'end'
ClosedPublic

Authored by dhaumann on Dec 8 2018, 5:16 PM.

Details

Summary

This warning was introduced with D17295 - this is a proposed fix.

Is there a better fix? Looking into the code, we can find more
StringDetect rules that use "end". Maybe the keyword list should
be used instead?

Test Plan

make && make test

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dhaumann created this revision.Dec 8 2018, 5:16 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptDec 8 2018, 5:16 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
dhaumann requested review of this revision.Dec 8 2018, 5:16 PM
dhaumann updated this revision to Diff 47134.Dec 8 2018, 5:18 PM
  • increase version number only by one :-)
cullmann accepted this revision.Dec 9 2018, 3:03 PM

If not used, I shall go, no need to have the warning around.

This revision is now accepted and ready to land.Dec 9 2018, 3:03 PM
This revision was automatically updated to reflect the committed changes.

Thanks for the fix, yes it is valid. Previously "end" was used as a standalone keyword, but keyword requires space after the word. Now it used in StringDetect to detect cases like "end sub" and "endsub" in the same rule.