Differential D17430

highlight token strings and delimited strings
ClosedPublic
Actions

Authored by aG0aep6G on Dec 8 2018, 2:42 PM.

Details

Reviewers
dhaumann
Commits
R216:2a928919366d: highlight token strings and delimited strings

Diff Detail

Repository
R216 Syntax Highlighting
Branch
tokenstring-delimitedstring
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5816
Build 5834: arc lint + arc unit
aG0aep6G created this revision.Dec 8 2018, 2:42 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptDec 8 2018, 2:42 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
aG0aep6G requested review of this revision.Dec 8 2018, 2:42 PM
aG0aep6G updated this revision to Diff 47371.Dec 11 2018, 6:03 PM
  • add test lines for token strings and delimited strings
dhaumann accepted this revision.Dec 12 2018, 12:14 AM
This revision is now accepted and ready to land.Dec 12 2018, 12:14 AM
dhaumann added a comment.Jan 3 2019, 8:03 PM

Unfortunately, this patch also has an issue:

XSDError in data/syntax/d.xml, at line 413, column 53: Element context is missing required attribute lineEndContext.

Can you provide an update to fix it?

aG0aep6G updated this revision to Diff 48636.Jan 3 2019, 8:08 PM
  • add missing lineEndContext attribute
aG0aep6G added a comment.Jan 3 2019, 8:09 PM
In D17430#386026, @dhaumann wrote:

Unfortunately, this patch also has an issue:

XSDError in data/syntax/d.xml, at line 413, column 53: Element context is missing required attribute lineEndContext.

Can you provide an update to fix it?

Done.

Closed by commit R216:2a928919366d: highlight token strings and delimited strings (authored by dhaumann). · Explain WhyJan 3 2019, 8:11 PM
This revision was automatically updated to reflect the committed changes.
dhaumann added a comment.Jan 3 2019, 8:12 PM

Also committed, hope everything merged nicely and is correct. I had to update the folding unit test data again, but I guess that is fine.
If you find any issues, please provide another patch :-)

Revision Contents
Changeset List

PathPackages
Mdata/syntax/d.xml (76 lines)

Diff 47115

View Options

data/syntax/d.xml

Loading...