Differential D17426

[effects] Drop static_cast in getMainWindows
ClosedPublic
Actions

Authored by zzag on Dec 8 2018, 11:54 AM.

Details

Reviewers
graesslin
Group Reviewers
KWin
Commits
R108:3dff1a8a675f: [effects] Drop static_cast in getMainWindows
Summary

We use a function template, so static_cast in getMainWindows looks out
of place. Also, it's not good idea to do static_cast based on output of
isDeleted().

Test Plan

The Dialog Parent effect works.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Dec 8 2018, 11:54 AM
Restricted Application added a project: KWin. · View Herald TranscriptDec 8 2018, 11:54 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Dec 8 2018, 11:54 AM
graesslin accepted this revision.Dec 8 2018, 12:24 PM
This revision is now accepted and ready to land.Dec 8 2018, 12:24 PM
zzag added a comment.Dec 8 2018, 12:27 PM

@graesslin Can I land this revision? Or I should wait until all tests pass again?

graesslin added a comment.Dec 8 2018, 12:59 PM
In D17426#373168, @zzag wrote:

@graesslin Can I land this revision? Or I should wait until all tests pass again?

For my own outstanding patches I decided to wait till the tests pass again.

Closed by commit R108:3dff1a8a675f: [effects] Drop static_cast in getMainWindows (authored by zzag). · Explain WhyDec 14 2018, 7:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Meffects.cpp (14 lines)

Diff 47580

View Options

effects.cpp

Loading...