[effects] Drop static_cast in getMainWindows
ClosedPublic

Authored by zzag on Dec 8 2018, 11:54 AM.

Details

Summary

We use a function template, so static_cast in getMainWindows looks out
of place. Also, it's not good idea to do static_cast based on output of
isDeleted().

Test Plan

The Dialog Parent effect works.

Diff Detail

Repository
R108 KWin
Branch
simplify-effectwindowimpl-mainwindows
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5807
Build 5825: arc lint + arc unit
zzag created this revision.Dec 8 2018, 11:54 AM
Restricted Application added a project: KWin. · View Herald TranscriptDec 8 2018, 11:54 AM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Dec 8 2018, 11:54 AM
graesslin accepted this revision.Dec 8 2018, 12:24 PM
This revision is now accepted and ready to land.Dec 8 2018, 12:24 PM
zzag added a comment.Dec 8 2018, 12:27 PM

@graesslin Can I land this revision? Or I should wait until all tests pass again?

In D17426#373168, @zzag wrote:

@graesslin Can I land this revision? Or I should wait until all tests pass again?

For my own outstanding patches I decided to wait till the tests pass again.

This revision was automatically updated to reflect the committed changes.