Falkon inserts incorrect history `count` data in sql

Authored by cullmann on Dec 8 2018, 5:39 AM.


Group Reviewers

Corrected the count of the history data
Bug 393341

Diff Detail

R875 Falkon
Lint Skipped
Unit Tests Skipped
krishremya created this revision.Dec 8 2018, 5:39 AM
Restricted Application added a subscriber: falkon. ยท View Herald TranscriptDec 8 2018, 5:39 AM
krishremya requested review of this revision.Dec 8 2018, 5:39 AM
cullmann requested changes to this revision.Dec 11 2018, 8:49 PM
cullmann added a subscriber: cullmann.

Hmm, I am not sure this helps, given x lines above one does:

before.count = count;

Therefore count == before.count, or?

This revision now requires changes to proceed.Dec 11 2018, 8:49 PM
drosca added a subscriber: drosca.Dec 12 2018, 8:07 PM

If by incorrect history count you mean that one page load results in counter incrementing by 2 instead of 1 then it is actually side-effect of this workaround: https://cgit.kde.org/falkon.git/tree/src/lib/webengine/webpage.cpp#n106

As @cullman noted, this has absolutely no effect at all.

cullmann commandeered this revision.Dec 26 2018, 9:29 PM
cullmann edited reviewers, added: krishremya; removed: cullmann.

Then lets abandon this change.

cullmann abandoned this revision.Dec 26 2018, 9:29 PM