Search for binary Qt resource, containing breeze theme. If found, register and use it.
ClosedPublic

Authored by arrowd on Jun 1 2016, 4:29 PM.

Diff Detail

Repository
R32 KDevelop
Branch
rcc (branched from 5.0)
Lint
No Linters Available
Unit
No Unit Test Coverage
arrowd updated this revision to Diff 4144.Jun 1 2016, 4:29 PM
arrowd retitled this revision from to Search for binary Qt resource, containing breeze theme. If found, register and use it..
arrowd updated this object.
arrowd edited the test plan for this revision. (Show Details)
arrowd added a reviewer: KDevelop.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJun 1 2016, 4:29 PM
arrowd updated this revision to Diff 4145.Jun 1 2016, 4:32 PM

Oops, this should be uncommented too.

kfunk requested changes to this revision.Jun 1 2016, 6:53 PM
kfunk added a reviewer: kfunk.
kfunk added a subscriber: kfunk.
kfunk added inline comments.
app/main.cpp
395

Why do we need two calls to QResource::registerResource with different roots?

I'd prefer if we can do it similar to Kate (a free function inside main.cpp would be enough).
See: https://quickgit.kde.org/?p=kate.git&a=blob&f=icons.h

This revision now requires changes to proceed.Jun 1 2016, 6:53 PM
arrowd added inline comments.Jun 1 2016, 6:55 PM
app/main.cpp
395

Why do we need two calls to QResource::registerResource with different roots?

To be honest, i don't know, but omitting any of them leaves KDevelop with no icons at all.

arrowd updated this revision to Diff 4146.Jun 1 2016, 7:09 PM
arrowd edited edge metadata.
arrowd marked an inline comment as done.

Addresscomments.

kfunk added inline comments.Jun 2 2016, 7:23 AM
app/main.cpp
395

Please try to figure out and give me a reasonable explanation :).

We're also not checking the return value from QResource::registerResource

arrowd updated this revision to Diff 4204.Jun 4 2016, 9:06 AM
arrowd edited edge metadata.

Register resource only once.

arrowd marked an inline comment as done.Jun 4 2016, 9:34 AM
kfunk accepted this revision.EditedJun 12 2016, 9:16 PM
kfunk edited edge metadata.

Looks good, gotta try it on Windows

This revision is now accepted and ready to land.Jun 12 2016, 9:16 PM