Added code example to actionbutton, contextdrawer, globaldrawer, menubar, toolbar
ClosedPublic

Authored by fabianr on Dec 7 2018, 8:27 AM.

Diff Detail

Repository
R985 KDE Human Interface Guidelines
Branch
code-examples
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5885
Build 5903: arc lint + arc unit
fabianr requested review of this revision.Dec 7 2018, 8:27 AM
fabianr created this revision.
fabianr updated this revision to Diff 47047.Dec 7 2018, 5:11 PM
  • Added code examples to menubar and toolbar
fabianr retitled this revision from Added code example to actionbutton contextdrawer globaldrawer to Added code example to actionbutton, contextdrawer, globaldrawer, menubar, toolbar.Dec 8 2018, 7:33 AM
fabianr edited the summary of this revision. (Show Details)
mart accepted this revision.Dec 10 2018, 9:29 AM

ship it with that little change on contextualActions

source/components/navigation/contextdrawer.rst
65

the contextualactions property right under page is kinda deprecated...can you put it under actions as well?
either actions.contextualActions: [..]
or
actions {

contextualActions: [...]

}

This revision is now accepted and ready to land.Dec 10 2018, 9:29 AM
fabianr updated this revision to Diff 47259.Dec 10 2018, 10:23 AM
  • Added qsTr() for all text lables
  • Replaced qsTr with i18n
fabianr updated this revision to Diff 47260.Dec 10 2018, 10:37 AM
  • Fixed small error in code example
fabianr marked an inline comment as done.Dec 10 2018, 10:41 AM
fabianr closed this revision.Dec 10 2018, 10:42 AM