Differential D17391

add support for more mimetypes to taglibwriter
ClosedPublic
Actions

Authored by astippich on Dec 6 2018, 6:47 PM.

Details

Reviewers
bruns
mgallien
Commits
R286:b6fa5f7245fb: add support for more mimetypes to taglibwriter
Summary

adds support for basic tag writing to
aiff, wav, wavpack, wma/asf, ape and speex files

Test Plan

tests pass

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Dec 6 2018, 6:47 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptDec 6 2018, 6:47 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Dec 6 2018, 6:47 PM
astippich added a comment.Jan 4 2019, 7:05 PM

friendly ping. this is pretty straightforward

bruns accepted this revision.Jan 4 2019, 9:54 PM
This revision is now accepted and ready to land.Jan 4 2019, 9:54 PM
Closed by commit R286:b6fa5f7245fb: add support for more mimetypes to taglibwriter (authored by astippich). · Explain WhyJan 7 2019, 8:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48918

View Options

autotests/taglibwritertest.cpp

Loading...
View Options

src/writers/taglibwriter.cpp

Loading...