Differential D17390

Fix lint warning: Avoid non-default constructors in fragments
ClosedPublic
Actions

Authored by eduisters on Dec 6 2018, 6:28 PM.

Details

Reviewers
nicolasfella
Group Reviewers
KDE Connect
Commits
R225:96a1edfb764d: Fix lint warning: Avoid non-default constructors in fragments
Summary

It is common practice to use a static newInstance to create new fragment instances instead of using non-default constructors

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eduisters created this revision.Dec 6 2018, 6:28 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 6 2018, 6:28 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
eduisters requested review of this revision.Dec 6 2018, 6:28 PM
nicolasfella accepted this revision.Dec 6 2018, 6:43 PM
This revision is now accepted and ready to land.Dec 6 2018, 6:43 PM
eduisters updated this revision to Diff 46996.Dec 6 2018, 7:28 PM

Rebased onto master

Closed by commit R225:96a1edfb764d: Fix lint warning: Avoid non-default constructors in fragments (authored by eduisters). · Explain WhyDec 6 2018, 7:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46997

View Options

src/org/kde/kdeconnect/UserInterface/DeviceFragment.java

Loading...
View Options

src/org/kde/kdeconnect/UserInterface/MainActivity.java

Loading...