Differential D17384

Do not send null NetworkPackets
ClosedPublic
Actions

Authored by eduisters on Dec 6 2018, 3:45 PM.

Details

Reviewers
nicolasfella
Group Reviewers
KDE Connect
Commits
R225:27f8c57c50e3: Do not send null NetworkPackets
Summary

queuedSendUriList can return null and subsequently an attempt is make to actually send this null packet

Diff Detail

Repository
R225 KDE Connect - Android application
Branch
do_not_send_null_packets
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5753
Build 5771: arc lint + arc unit
eduisters created this revision.Dec 6 2018, 3:45 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 6 2018, 3:45 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
eduisters requested review of this revision.Dec 6 2018, 3:45 PM
nicolasfella added a subscriber: nicolasfella.Dec 6 2018, 3:52 PM
nicolasfella added inline comments.
src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java
290

toSend.add(np) ?

eduisters marked an inline comment as done.Dec 6 2018, 3:56 PM
nicolasfella accepted this revision.Dec 6 2018, 6:07 PM
This revision is now accepted and ready to land.Dec 6 2018, 6:07 PM
Closed by commit R225:27f8c57c50e3: Do not send null NetworkPackets (authored by eduisters). · Explain WhyDec 6 2018, 6:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46970

View Options

src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java

Loading...