Don't use kcmshell5 for opening the KCM
ClosedPublic

Authored by nicolasfella on Thu, Dec 6, 3:04 PM.

Details

Summary

kcmshell5 depends on plasma-workspace. By using our own tiny wrapper for opening the KCM we avoid pulling
in plasma-workspace and everything that comes with it on non-Plasma systems.

Test Plan

kdeconnect-settings shows the KCM

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Thu, Dec 6, 3:04 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptThu, Dec 6, 3:04 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Thu, Dec 6, 3:04 PM
  • Add missing file
  • Correct license header
sredman accepted this revision.Thu, Dec 6, 8:39 PM
sredman added a subscriber: sredman.

It works for me. I like this a lot better than before because I could never remember how to launch the settings panel! If you like, I can test it on my Ubuntu 18.04 Gnome VM before you merge.

This revision is now accepted and ready to land.Thu, Dec 6, 8:39 PM
This revision was automatically updated to reflect the committed changes.

I think this is fine as a temporary solution but we should look into fixing kcmshell dependencies. It uses KWorkspace lib from plasma-workspace for determining the Qt platform to use. And that ends up pulling in everything and the kitchen sink :/