Differential D17376

Missing Comment in desktop file
ClosedPublic
Actions

Authored by krishremya on Dec 6 2018, 4:37 AM.

Details

Reviewers
cfeck
yurchor
Group Reviewers
KTurtle
Commits
R337:be45b42feaad: Missing Comment in desktop file
Summary

Added a comment in the desktop file in Kturtle.
Bug ID: 351968

Diff Detail

Repository
R337 KTurtle
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
krishremya created this revision.Dec 6 2018, 4:37 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptDec 6 2018, 4:37 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
krishremya requested review of this revision.Dec 6 2018, 4:37 AM
cfeck requested changes to this revision.Dec 6 2018, 5:26 AM
cfeck added a subscriber: cfeck.

Please set the correct diff.

This revision now requires changes to proceed.Dec 6 2018, 5:26 AM
yurchor added a subscriber: yurchor.Dec 6 2018, 5:29 AM

I think that the reporter meant this file:

https://cgit.kde.org/kturtle.git/tree/src/org.kde.kturtle.desktop

It is enough to add

Comment=Educational Programming Environment

in that file to fix the bug.

krishremya updated this revision to Diff 46936.Dec 6 2018, 5:46 AM

Changed the comment on the desktop file to "Educational Programming Environment"

yurchor added a comment.Dec 6 2018, 1:58 PM

Sorry, but this is wrong again. :'(

Please, just add

Comment=Educational Programming Environment

into the line after

GenericName[zh_TW]=教育程式環境

in /src/org.kde.kturtle.desktop

This is needed for menus in some desktop environments. Thanks.

krishremya updated this revision to Diff 46962.Dec 6 2018, 2:50 PM

Updated the comment in the correct position.

yurchor added a comment.Dec 6 2018, 5:26 PM

Please do not patch AppData file.

It was asked to patch desktop file, /src/org.kde.kturtle.desktop in the /src subfolder.

This patch should look like https://paste.kde.org/pzki9tctu/z2vxvn

Thanks for your patience.

krishremya updated this revision to Diff 47087.Dec 8 2018, 6:35 AM
yurchor accepted this revision.Dec 8 2018, 6:40 AM

Thanks.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 8 2018, 10:58 AM
Closed by commit R337:be45b42feaad: Missing Comment in desktop file (authored by krishremya, committed by aacid). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/org.kde.kturtle.desktop (1 line)

Diff 47094

View Options

src/org.kde.kturtle.desktop

Loading...