Differential D17369

Add touch support to x11 windowed platform
ClosedPublic
Actions

Authored by graesslin on Dec 5 2018, 6:13 PM.

Details

Reviewers

davidedmundson

Group Reviewers

KWin

Commits

R108:d49642ca151f: Add touch support to x11 windowed platform

Summary

This change inits XInput extension, listens for touch events and
forwards them to our platform API. Thus touch events are forwarded on a
nested wayland session on X11.

Please note that I only tested this change on Xwayland.

Test Plan

Run nested kwin_wayland with two outputs and looked into debug console

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin created this revision.Dec 5 2018, 6:13 PM

Restricted Application added a project: KWin. · View Herald TranscriptDec 5 2018, 6:13 PM

Restricted Application added a subscriber: kwin. · View Herald Transcript

graesslin requested review of this revision.Dec 5 2018, 6:13 PM

Harbormaster completed remote builds in B5727: Diff 46911.Dec 5 2018, 6:13 PM

zzag added a subscriber: zzag.Dec 5 2018, 6:27 PM

zzag added inline comments.

plugins/platforms/x11/windowed/x11windowed_backend.cpp
146	Shouldn't it be just m_hasXInput = true?
233	Missing Q_UNUSED.

graesslin added inline comments.Dec 5 2018, 8:07 PM

plugins/platforms/x11/windowed/x11windowed_backend.cpp
146	No, that was on purpose. It's the minimum version supporting touch.

Q_UNUSED

Harbormaster completed remote builds in B5733: Diff 46917.Dec 5 2018, 8:35 PM

davidedmundson accepted this revision.Dec 19 2018, 1:44 PM

davidedmundson added a subscriber: davidedmundson.

davidedmundson added inline comments.

plugins/platforms/x11/windowed/x11windowed_backend.cpp
253	would be best in x11/common as a new file rather than duplicating it

This revision is now accepted and ready to land.Dec 19 2018, 1:44 PM

graesslin added inline comments.Dec 19 2018, 5:42 PM

plugins/platforms/x11/windowed/x11windowed_backend.cpp
253	Sure can do that. I didn't want to touch the standalone code as I don't test that any more.

Move GeEventMemMover into dedicated header

Harbormaster completed remote builds in B6244: Diff 47969.Dec 21 2018, 4:23 PM

Closed by commit R108:d49642ca151f: Add touch support to x11 windowed platform (authored by graesslin). · Explain WhyDec 31 2018, 7:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
A	M	plugins/platforms/x11/common/ge_event_mem_mover.h (55 lines)
M		plugins/platforms/x11/standalone/xinputintegration.cpp (27 lines)
M		plugins/platforms/x11/windowed/CMakeLists.txt (3 lines)
M		plugins/platforms/x11/windowed/x11windowed_backend.h (7 lines)
M		plugins/platforms/x11/windowed/x11windowed_backend.cpp (112 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	46911	37060a6		Dec 5 2018, 6:13 PM	★	★
Diff 2	46917	37060a6	Q_UNUSED	Dec 5 2018, 8:35 PM	★	★
Diff 3	47969	f306072	Move GeEventMemMover into dedicated header	Dec 21 2018, 4:23 PM	★	★
Diff 4	48429	f762802	R108:d49642ca151f4d793d7da70f879b00d3ed9d5b22	Dec 31 2018, 6:57 AM	★	★