Differential D17368

Fixed bug that crashed program when clicking Forecast->Chart
ClosedPublic
Actions

Authored by joaonetto on Dec 5 2018, 1:42 PM.

Details

Reviewers
tbaumgart
Group Reviewers
KMyMoney
Commits
R261:c74bde8a1599: Fixed bug that crashed program when clicking Forecast->Chart
R261:6ba86e8d02dc: Fixed bug that crashed program when clicking Forecast->Chart
Summary

BUG: 400820

Diff Detail

Repository
R261 KMyMoney
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5722
Build 5740: arc lint + arc unit
joaonetto requested review of this revision.Dec 5 2018, 1:42 PM
joaonetto created this revision.
shubham edited the summary of this revision. (Show Details)Dec 5 2018, 1:44 PM
joaonetto updated this revision to Diff 46899.Dec 5 2018, 1:46 PM

Forgot to delete debug options. Updated it

joaonetto updated this revision to Diff 46923.Dec 5 2018, 10:32 PM

QString should be const, fixed it.

tbaumgart accepted this revision.Dec 6 2018, 9:56 AM
tbaumgart added a subscriber: tbaumgart.

Nice catch. Seems to be the old auto and QStringBuilder issue. See https://docs.kdab.com/analysis/share/clazy-explain.html and search for auto-unexpected-qstringbuilder for more details. If you need help landing it please let me know.

This revision is now accepted and ready to land.Dec 6 2018, 9:56 AM
joaonetto added a comment.Dec 6 2018, 10:39 AM

I can't land or commit to repository since I'm not a KDE dev.

Closed by commit R261:6ba86e8d02dc: Fixed bug that crashed program when clicking Forecast->Chart (authored by joaonetto, committed by tbaumgart). · Explain WhyDec 6 2018, 11:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46898

View Options

kmymoney/plugins/views/forecast/kforecastview_p.h

Loading...
View Options

kmymoney/plugins/views/reports/reportsview.cpp

Loading...