Implement "Kill" button when sysguard was invoked from freememorynotifier
AcceptedPublic

Authored by McPain on Dec 5 2018, 11:10 AM.

Details

Reviewers
mart
Summary

If ksysguard was invoked from freememorynotifier directly, every process is displayed with its own kill button.
In most "OOM-risky" cases it is required to kill one and only one process.

Clicking on his own "Kill" button is cheaper than selecting it from list and clicking the main "Kill" button (2 clicks > 1 click)
Also, you cannot hide this column by accident or show it when invoked by hotkey (Ctrl+Esc by default).

Since it's invoked with --ignore-config option I implemented earlier (D17217) any layout changes won't be stored in config.

Diff Detail

Repository
R111 KSysguard Library
Lint
Lint Skipped
Unit
Unit Tests Skipped
McPain created this revision.Dec 5 2018, 11:10 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 5 2018, 11:10 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
McPain requested review of this revision.Dec 5 2018, 11:10 AM
mart accepted this revision.Dec 14 2018, 4:16 PM
This revision is now accepted and ready to land.Dec 14 2018, 4:16 PM
aacid added a subscriber: aacid.Jan 16 2019, 11:18 PM

Should this be landed even if D17217 has not landed?

D17217 is a non-starter, for all the reasons given in the review for that patch. Since it's a prerequisite of this, it doesn't make sense to land this until and unless D17217 lands.