Differential D17365

Round label width
ClosedPublic
Actions

Authored by fvogt on Dec 5 2018, 9:35 AM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R119:3526334e8234: Round label width
R119:02ef57d37b2c: Merge branch 'Plasma/5.14'
Summary

Currently the icon labels can be at non-integer positions.
This results in ugly font rendering.

Test Plan

Before/after:

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Dec 5 2018, 9:35 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 5 2018, 9:35 AM
fvogt requested review of this revision.Dec 5 2018, 9:35 AM
fvogt edited the test plan for this revision. (Show Details)Dec 5 2018, 9:46 AM
broulik added a subscriber: broulik.Dec 5 2018, 9:48 AM
broulik added inline comments.
containments/desktop/package/contents/ui/FolderItemDelegate.qml
66

That's what this hideous code is actually supposed to do

fvogt added inline comments.Dec 5 2018, 9:50 AM
containments/desktop/package/contents/ui/FolderItemDelegate.qml
66

It doesn't work though - I'll check some more.

fvogt updated this revision to Diff 46884.Dec 5 2018, 9:51 AM

Turns out the label width rounding is enough

fvogt retitled this revision from Round folder view delegate and label positions to Round label width.Dec 5 2018, 9:52 AM
fvogt edited the summary of this revision. (Show Details)
fvogt marked 2 inline comments as done.
broulik accepted this revision.Dec 5 2018, 9:53 AM

Cool! Stable branch pls

This revision is now accepted and ready to land.Dec 5 2018, 9:53 AM
Closed by commit R119:3526334e8234: Round label width (authored by fvogt). · Explain WhyDec 5 2018, 9:55 AM
This revision was automatically updated to reflect the committed changes.
ngraham added a subscriber: ngraham.Dec 5 2018, 2:44 PM

Hmm, the "After" pictured depicts terrible kerning. Take a look at "Discover" in particular. Is this really the trade-off we're faced with? It feels like there are upstream Qt bugs here.

fvogt added a comment.Dec 5 2018, 3:14 PM

Hmm, the "After" pictured depicts terrible kerning. Take a look at "Discover" in particular. Is this really the trade-off we're faced with? It feels like there are upstream Qt bugs here.

Yup, definitely. Font rendering in QML has some issues.

FreeType hinting configuration and especially the used font can make a huge difference though. With "Roboto" for example it looks perfectly fine.

Revision Contents
Changeset List

Diff 46886

View Options

containments/desktop/package/contents/ui/FolderItemDelegate.qml

Loading...