[RFC] [FormLayout] Top-align item labels

Authored by ngraham on Dec 4 2018, 8:35 PM.


Group Reviewers

Top-align FormLayout item labels so that they're aligned correctly for tall items. For an example of where this would be useful, see D17354#371280.

This is an RFC because this code is pretty complex and I'm sure I did it wrong (see test plan section).

Test Plan

(the general mis-alignment of the labels with the text in the checkboxes is a pre-existing issue, which I have crudely attempted to fix with D17361)

However, now labels elsewhere are too high and I can't figure out where this is happening:

Diff Detail

R169 Kirigami
top-aligned-left-labels (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 5707
Build 5725: arc lint + arc unit
ngraham created this revision.Dec 4 2018, 8:35 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptDec 4 2018, 8:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Dec 4 2018, 8:35 PM
ngraham edited the summary of this revision. (Show Details)Dec 4 2018, 8:38 PM
ngraham edited the test plan for this revision. (Show Details)
ngraham added reviewers: Kirigami, mart.
ngraham abandoned this revision.Dec 6 2018, 3:17 PM

Not necessary; found a way to implement this goal in D17362 without changes to Kirigami.