Differential D1736

Use QObject's parent to memory-manage the timers
ClosedPublic
Actions

Authored by sebas on Jun 1 2016, 2:57 PM.

Details

Reviewers
graesslin
Commits
R104:13a03dc11bb0: Use QObject's parent to memory-manage the timers
Summary

Use QObject's memory management tricks by parenting the timers.

Test Plan

kded5 still works

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sebas updated this revision to Diff 4138.Jun 1 2016, 2:57 PM
sebas retitled this revision from to Use QObject's parent to memory-manage the timers.
sebas updated this object.
sebas edited the test plan for this revision. (Show Details)
sebas added a reviewer: graesslin.
sebas added a subscriber: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 1 2016, 2:57 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin accepted this revision.Jun 1 2016, 2:58 PM
graesslin edited edge metadata.
This revision is now accepted and ready to land.Jun 1 2016, 2:58 PM
sebas updated this revision to Diff 4139.Jun 1 2016, 3:00 PM
sebas edited edge metadata.
  • Use QScopedPointer for the elapsed timer
graesslin added a comment.Jun 1 2016, 3:01 PM

As I cannot accept again: ShipIt

Closed by commit R104:13a03dc11bb0: Use QObject's parent to memory-manage the timers (authored by sebas). · Explain WhyJun 1 2016, 3:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkded/daemon.h (2 lines)
Mkded/daemon.cpp (14 lines)

Diff 4140

View Options

kded/daemon.h

Loading...
View Options

kded/daemon.cpp

Loading...