Differential D17358

implement cover extraction for asf files
ClosedPublic
Actions

Authored by astippich on Dec 4 2018, 7:30 PM.

Details

Reviewers
bruns
mgallien
Commits
R286:2a41e4b45262: implement cover extraction for asf files
Summary

implement support for last missing mimetype
compared to tagllibextractor

Test Plan

test passes

Diff Detail

Repository
R286 KFileMetaData
Branch
wma_cover
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5705
Build 5723: arc lint + arc unit
astippich created this revision.Dec 4 2018, 7:30 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptDec 4 2018, 7:30 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Dec 4 2018, 7:30 PM
bruns accepted this revision.Dec 4 2018, 11:43 PM
bruns added inline comments.
src/embeddedimagedata.cpp
273

Nitpick - empty line between functions

This revision is now accepted and ready to land.Dec 4 2018, 11:43 PM
Closed by commit R286:2a41e4b45262: implement cover extraction for asf files (authored by astippich). · Explain WhyDec 6 2018, 6:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46868

View Options

autotests/embeddedimagedatatest.cpp

Loading...
View Options

autotests/samplefiles/test.wma

Loading...
View Options

src/embeddedimagedata.cpp

Loading...