Translate color scheme names
ClosedPublic

Authored by broulik on Dec 4 2018, 3:25 PM.

Details

Summary

BUG: 401136
FIXED-IN: 5.15.0

Test Plan

The KCM reads e.g. Name[de]=Honigwabe but we never extracted them.
Dunno if that works but translators told me it would :)

(Will do a similar patch for Breeze once this is in and CCBUG)

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 4 2018, 3:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 4 2018, 3:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 4 2018, 3:25 PM
broulik edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Dec 4 2018, 3:27 PM
This revision is now accepted and ready to land.Dec 4 2018, 3:27 PM
This revision was automatically updated to reflect the committed changes.
lueck added a comment.Dec 4 2018, 3:56 PM

@broulik thanks.
this was commited to master, but should go into stable and lts.
making strings translatable does not break the string freeze

making strings translatable does not break the string freeze

I know but changing the names (and as such the order of in the list) of themes that haven't been translated forever I think isn't ideal for a stable or LTS.

It seems most codepaths assume the colorscheme names are never translated...
KColorSchemeManager uses the Qt::DisplayRole for mapping. The Qt::UserRole contains the full path to the scheme but it never stores just the untranslated name.
Affects Krita, Kate, etc, which lost my "Honeycomb" colorscheme now that it's called "Honigwabe". Setting it again works but changing languages causes the mapping to fail.
(See, that's why I didn't put it in stable branches :)