Support Bluetooth batteries
ClosedPublic

Authored by broulik on Dec 4 2018, 2:31 PM.

Details

Summary

Test Plan

Depends on D17345

VDG I need a plasma icon for this, can also just be a generic bluetooth icon, but something black and white in preferences.svgz named preferences-system-bluetooth-battery

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Dec 4 2018, 2:31 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 4 2018, 2:31 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Dec 4 2018, 2:31 PM
ngraham edited the test plan for this revision. (Show Details)Dec 4 2018, 2:40 PM
ndavis added a subscriber: ndavis.Dec 10 2018, 11:35 AM

Does it have to be in the Plasma theme? I want to move all icons into breeze-icons eventually.

Does it have to be in the Plasma theme?

Yes, to be consistent with the other Bluetooth icons we have in there

abetts added a subscriber: abetts.Dec 10 2018, 3:46 PM

Maybe not applicable to this patch, but would we consider making the battery color in the progress bar to be green? Green seems to be very standard to mean charge. We are using blue.

No. Can we not digress from this, I just need an icon...

No. Can we not digress from this, I just need an icon...

:**(

It's all good. Just a thought.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 13 2018, 8:01 AM
This revision was automatically updated to reflect the committed changes.