Use localizable string list separator
ClosedPublic
Actions

Authored by yurchor on Dec 4 2018, 1:48 PM.

Details

Reviewers

ngraham
astippich

Commits

R824:c3753456418f: Use localizable string list separator

Summary

Wikipedia article [1] says that the rule to use ", " is not universal (at least for Arabic-based and CJK locales).

Discussion in the translator list:

CLDR rules for Japanese:

for Arabic:

for Chinese:

Test Plan

Should be compilable (not tested).

Repository

R824 Baloo Widgets

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a project: Baloo. · View Herald TranscriptDec 4 2018, 1:48 PM

Restricted Application added a subscriber: Baloo. · View Herald Transcript

yurchor requested review of this revision.Dec 4 2018, 1:48 PM

Whoops, nice catch! Discussion and patch make sense to me.

This revision is now accepted and ready to land.Dec 4 2018, 2:50 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/widgetfactory.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	46833			Dec 4 2018, 1:39 PM	★	★
Diff 2	46849	2fb3ab4	R824:c3753456418f6233561723ffd89a847e89ec2468	Dec 4 2018, 5:16 PM	★	★