Use localizable string list separator
ClosedPublic

Authored by yurchor on Tue, Dec 4, 1:48 PM.

Details

Summary

Wikipedia article [1] says that the rule to use ", " is not universal (at least for Arabic-based and CJK locales).

[1] https://en.wikipedia.org/wiki/Comma#In_other_languages

Discussion in the translator list:

https://marc.info/?t=154385774700004&r=1&w=2

CLDR rules for Japanese:

https://www.unicode.org/cldr/charts/34/summary/ja.html#6518

for Arabic:

https://www.unicode.org/cldr/charts/34/summary/ar.html#8937

for Chinese:

https://www.unicode.org/cldr/charts/34/summary/yue_Hans.html#6423

Test Plan

Should be compilable (not tested).

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor created this revision.Tue, Dec 4, 1:48 PM
Restricted Application added a project: Baloo. · View Herald TranscriptTue, Dec 4, 1:48 PM
Restricted Application added a subscriber: Baloo. · View Herald Transcript
yurchor requested review of this revision.Tue, Dec 4, 1:48 PM
ngraham accepted this revision.Tue, Dec 4, 2:50 PM

Whoops, nice catch! Discussion and patch make sense to me.

This revision is now accepted and ready to land.Tue, Dec 4, 2:50 PM
This revision was automatically updated to reflect the committed changes.