Added team-port setting according to:
https://developer.gnome.org/NetworkManager/stable/settings-team-port.html
Details
- Reviewers
jgrulich - Commits
- R282:d3ca739a37ab: team-port setting
Diff Detail
- Repository
- R282 NetworkManagerQt
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
autotests/settings/teamportsettingtest.cpp | ||
---|---|---|
30 | Those defines are already in NM 1.10 | |
63 | set it to TRUE, otherwise it will fail once you fix the test | |
93 | This is weird, this way only link-watchers should be compared, the rest should be identical to other unit tests. | |
src/settings/setting.cpp | ||
34 | NM 1.10.0 | |
src/settings/teamportsetting.cpp | ||
27 | NM 1.10.0 | |
211 |
| |
215 | != 255 | |
219 |
|
autotests/settings/teamportsettingtest.cpp | ||
---|---|---|
98 | Still weird, why don't you put link-watchers to the same map as above. You can then skip comparison if the key is "link-watchers" as you saw in ipv6settingtest for example. | |
121 | Here you compare whether the maps have identical keys, which is correct, but you also have to compare the values. | |
src/settings/teamportsetting.cpp | ||
45 | Default property initialization is missing. | |
227 | This is wrong, default value is FALSE, which means you would skip this property if it's set. |
autotests/settings/teamportsettingtest.cpp | ||
---|---|---|
104 | Why don't you skip this and just use NMVariantMapList list = map.value(QLatin1String(NM_SETTING_TEAM_PORT_LINK_WATCHERS).value<NMVariantMapList>()? same for the second one. You don't need to go through the map to get "link-watchers" property. |
I lived in assumption that "link-watchers" is NMVariantMapMap and not NMVariantMapList, that's why I suggested those changes. I'm sorry for that. I'll fix it locally here, you were correct before. The rest looks good.