BuildView: Fix broken load of project plugin targets
ClosedPublic

Authored by loh.tar on Dec 3 2018, 7:29 PM.

Details

Summary

Most changes are only a little code cosmetic, like unwrap lines or remove spaces

Test Plan

Here it was reproducible e.g. by changing between my sessions "kate" and "sonnet". I think you can guess what they are.

  1. Start Kate with session "kate" -> Project Targets shown
  2. Switch to "sonnet" -> No Project Targets shown. I think there are no (however) defined (any illuminating tip is appreciated)
  3. Switch back to "kate" -> Also NO Project Targets shown, but should!

With this patch are at 3. the Project Targets back again

Diff Detail

Repository
R40 Kate
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
loh.tar created this revision.Dec 3 2018, 7:29 PM
Restricted Application added a project: Kate. · View Herald TranscriptDec 3 2018, 7:29 PM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Dec 3 2018, 7:29 PM
sars accepted this revision.Dec 3 2018, 7:47 PM
sars added a subscriber: sars.

It is maybe not optimal to "hide" a bug fix among a bunch of code cosmetics, but the fix is good :)

This revision is now accepted and ready to land.Dec 3 2018, 7:47 PM
In D17339#370901, @sars wrote:

It is maybe not optimal to "hide" a bug fix among a bunch of code cosmetics

I agree, but didn't want to bother with an extra patch nor ignore these ugliness

, but the fix is good :)

Thanks

This revision was automatically updated to reflect the committed changes.