Extend PositionCodec unit tests, better code coverage
ClosedPublic

Authored by bruns on Dec 3 2018, 2:54 PM.

Details

Summary

The test never tested position increments larger than 1, as the positions
where divided by the docId. Multibyte (i.e. value >= 128) position
steps where completely omitted.

Use identical datasets in the functional tests and in the benchmarks.

Test Plan

ctest

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Dec 3 2018, 2:54 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptDec 3 2018, 2:54 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Dec 3 2018, 2:54 PM
lbeltrame accepted this revision.Dec 19 2018, 8:07 PM
This revision is now accepted and ready to land.Dec 19 2018, 8:07 PM
This revision was automatically updated to reflect the committed changes.