Don't break when it's set to null to unset metadata.
BUG: 401636
davidedmundson | |
fvogt |
Plasma |
Don't break when it's set to null to unset metadata.
BUG: 401636
https://www.youtube.com/tv (which I didn't know existed) now works and shows video title as metadata
Media Sessions demo page still works
Lint Skipped |
Unit Tests Skipped |
It can, processMetadata(data.value(QStringLiteral("metadata")).toObject()); turns it into an empty object when null (or anything but an Object)
Yes, but in there it calls data.value for multiple keys without checking anything - if that is intentional, it deserves a comment at least.
Yes, but in there it calls data.value for multiple keys without checking anything
Because it doesn't need to. It makes no difference whether the object is empty or has only one of the keys I read.
Because it doesn't need to. It makes no difference whether the object is empty or has only one of the keys I read.
Of course, but it's not obvious that this behaviour is actually wanted there.