Don't break when it's set to null to unset metadata.
BUG: 401636
Details
Details
- Reviewers
davidedmundson fvogt - Group Reviewers
Plasma - Commits
- R856:ee0070a6bd03: Make media session property setter more resilient
https://www.youtube.com/tv (which I didn't know existed) now works and shows video title as metadata
Media Sessions demo page still works
Diff Detail
Diff Detail
- Repository
- R856 Plasma Browser Integration
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
It can, processMetadata(data.value(QStringLiteral("metadata")).toObject()); turns it into an empty object when null (or anything but an Object)
Comment Actions
Yes, but in there it calls data.value for multiple keys without checking anything - if that is intentional, it deserves a comment at least.
Comment Actions
Yes, but in there it calls data.value for multiple keys without checking anything
Because it doesn't need to. It makes no difference whether the object is empty or has only one of the keys I read.
Comment Actions
Because it doesn't need to. It makes no difference whether the object is empty or has only one of the keys I read.
Of course, but it's not obvious that this behaviour is actually wanted there.