Differential D17322

Fix display of string lists
ClosedPublic
Actions

Authored by astippich on Dec 2 2018, 7:52 PM.

Details

Reviewers
ngraham
Group Reviewers
Baloo
Commits
R824:2ec4467468af: Fix display of string lists
Summary

toString() will output an empty string when
it is applied to a string list with more than one entry.
Add an explicit path for string lists and do the correct
join()

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Dec 2 2018, 7:52 PM
Restricted Application added a project: Baloo. · View Herald TranscriptDec 2 2018, 7:52 PM
Restricted Application added a subscriber: Baloo. · View Herald Transcript
astippich requested review of this revision.Dec 2 2018, 7:52 PM
astippich added a comment.Dec 2 2018, 7:53 PM

Unfortunately I missed the deadline with this one for Applications 18.12. I don't know the exact criteria if this is acceptable for stable or not.

ngraham accepted this revision.Dec 2 2018, 8:34 PM

This doesn't add any new translated strings and fixes a bug, so I think it's appropriate to go into Applications/18.12.

This revision is now accepted and ready to land.Dec 2 2018, 8:34 PM
Closed by commit R824:2ec4467468af: Fix display of string lists (authored by astippich). · Explain WhyDec 2 2018, 8:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/widgetfactory.cpp (3 lines)

Diff 46754

View Options

src/widgetfactory.cpp

Loading...