Changes the panel edit mode icon from a hamburger icon to a configure icon (as suggested in this Phabricator task: https://phabricator.kde.org/T10047).
Details
Details
- Reviewers
ngraham davidedmundson - Group Reviewers
Plasma VDG - Maniphest Tasks
- T10047: Guerilla UX testing: a GNOME switcher
- Commits
- R119:1ae7f9fece38: Change panel edit mode icon from from a hamburger icon to a configure icon
Look at the panel.
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
For the panel edit mode button, I think this is 100% appropriate since it opens a configuration UI. For the toolbox, I'm not as convinced yet, since clicking on it opens a menu with a number of non-configuration-related menu items. It's not the biggest deal, but it does feel a bit odd.
Thoughts?
Comment Actions
If Nate and Andy say to use this icon, go for it.
One code change
toolboxes/paneltoolbox/contents/ui/main.qml | ||
---|---|---|
57–58 | This doesn't make sense.. We're re-evaulating because hasElement might have changed when switching themes. |
toolboxes/paneltoolbox/contents/ui/main.qml | ||
---|---|---|
57–58 | So just remove the line? |