Differential D17298

remove unused docId from result
ClosedPublic
Actions

Authored by astippich on Dec 2 2018, 11:07 AM.

Details

Reviewers
bruns
ngraham
Group Reviewers
Baloo
Commits
R293:647823d36592: remove unused docId from result
Summary

The doc id in result class is never set and
never read, so remove it. The id can be
retrieved from the document itself.

Test Plan

compiles

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Dec 2 2018, 11:07 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptDec 2 2018, 11:07 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
astippich requested review of this revision.Dec 2 2018, 11:07 AM
bruns added a comment.Dec 2 2018, 3:12 PM

Addition - the document id is also stored and can be retrieved from the Baloo::Document.

astippich retitled this revision from remove unused doc_id from result to remove unused docId from result.Dec 2 2018, 5:54 PM
astippich edited the summary of this revision. (Show Details)
ngraham added a subscriber: ngraham.Dec 2 2018, 6:37 PM

Some of these are public; wouldn't this break ABI compatibility?

bruns added a comment.Dec 2 2018, 7:28 PM

libKF5BalooEngine is not exported to the outside world.

bruns accepted this revision.Dec 2 2018, 7:30 PM
This revision is now accepted and ready to land.Dec 2 2018, 7:30 PM
ngraham accepted this revision.Dec 2 2018, 7:30 PM

Ah, of course, duh!

Closed by commit R293:647823d36592: remove unused docId from result (authored by astippich). · Explain WhyDec 2 2018, 7:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46743

View Options

src/file/extractor/result.h

Loading...
View Options

src/file/extractor/result.cpp

Loading...