Differential D17295

BrightScript: Add function/sub folding
ClosedPublic
Actions

Authored by dlevin on Dec 2 2018, 6:42 AM.

Details

Reviewers
cullmann
Commits
R216:50a65cb06c37: BrightScript: Add function/sub folding
Summary

Global and local function folding, including closures.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Lint Skipped
Unit
Unit Tests Skipped
dlevin created this revision.Dec 2 2018, 6:42 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptDec 2 2018, 6:42 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
dlevin requested review of this revision.Dec 2 2018, 6:42 AM
dlevin updated this revision to Diff 46667.Dec 2 2018, 6:52 AM

Increased version number.

cullmann accepted this revision.Dec 2 2018, 12:34 PM

Ok, thanks!

This revision is now accepted and ready to land.Dec 2 2018, 12:34 PM
Closed by commit R216:50a65cb06c37: BrightScript: Add function/sub folding (authored by dlevin, committed by cullmann). · Explain WhyDec 2 2018, 12:36 PM
This revision was automatically updated to reflect the committed changes.
dhaumann added a subscriber: dhaumann.Dec 8 2018, 5:12 PM
dhaumann added inline comments.
data/syntax/brightscript.xml
290

Since this context is not used anymore, we gen a warning while creating the highlighting index:

[  9%] Generating index.katesyntax
testkatehighlightingindexer(31350)/(default) ::KeywordChecker::check: "/home/dh/kde/kf5/src/frameworks/syntax-highlighting/data/syntax/brightscript.xml" Unused keyword lists: QSet("end")

--> the keyword list end should be removed, since unused.

Revision Contents
Changeset List

Diff 46667

View Options

autotests/folding/brightscript.brs.fold

Loading...
View Options

data/syntax/brightscript.xml

Loading...