BUG: 397078
Fixes the hardcoded private browsing icon in the Falkon application menu.
drosca |
Falkon |
BUG: 397078
Fixes the hardcoded private browsing icon in the Falkon application menu.
Open the Falkon application menu on the top right.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Maybe in your icon theme.
There is no "standard" icon for this action, so that's why it uses hardcoded icon.
It looks like the original one in Breeze too...
Is the icon "visibility" or "hint" better?
The hardcoded icon is a problem, when you use a dark theme.
From the HIG:
"Use icons from the system icon theme whenever possible. Avoid using custom icons. New icons should be added to an icon theme."
Yes, so there should be new icon in Breeze theme (eg. private-browsing or maybe better private-mode so it is more generic) and then Falkon can use it.
Ok, but what should it look like, because the existing Breeze icons I told you about already look like a "private browsing/private mode" icon.
@drosca, you'll need to land this for @GB_ with authorship information Björn Feber <feber70@gmail.com>.
GB_2, have you considered applying for a Developer account so you can land your own patches? See https://community.kde.org/Infrastructure/Get_a_Developer_Account