Differential D17282

Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups
ClosedPublic
Actions

Authored by bruns on Dec 1 2018, 4:44 PM.

Details

Reviewers
ngraham
astippich
Group Reviewers
Baloo
Frameworks
Commits
R293:8efa39d4bbf1: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups
Test Plan

ctest
no functional changes

Diff Detail

Repository
R293 Baloo
Branch
submit
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5582
Build 5600: arc lint + arc unit
bruns created this revision.Dec 1 2018, 4:44 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptDec 1 2018, 4:44 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Dec 1 2018, 4:44 PM
ngraham added a comment.Dec 2 2018, 3:52 AM

Weird, why does Phabricator think termgeneratortest.cpp is a binary file?

astippich added a comment.Dec 2 2018, 11:46 AM
In D17282#369617, @ngraham wrote:

Weird, why does Phabricator think termgeneratortest.cpp is a binary file?

I'm wondering the same.

astippich accepted this revision.Dec 2 2018, 11:46 AM
This revision is now accepted and ready to land.Dec 2 2018, 11:46 AM
bruns added a comment.Dec 2 2018, 1:07 PM

Because the original file is latin1, thus not decodable as utf8, so it has to be binary ...
Stupid arc/phabricator

Closed by commit R293:8efa39d4bbf1: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups (authored by bruns). · Explain WhyDec 2 2018, 3:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46628

View Options

autotests/unit/engine/termgeneratortest.cpp

Loading...