Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups
ClosedPublic

Authored by bruns on Dec 1 2018, 4:44 PM.

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Dec 1 2018, 4:44 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptDec 1 2018, 4:44 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
bruns requested review of this revision.Dec 1 2018, 4:44 PM

Weird, why does Phabricator think termgeneratortest.cpp is a binary file?

Weird, why does Phabricator think termgeneratortest.cpp is a binary file?

I'm wondering the same.

astippich accepted this revision.Dec 2 2018, 11:46 AM
This revision is now accepted and ready to land.Dec 2 2018, 11:46 AM
bruns added a comment.Dec 2 2018, 1:07 PM

Because the original file is latin1, thus not decodable as utf8, so it has to be binary ...
Stupid arc/phabricator

This revision was automatically updated to reflect the committed changes.