This gets rid of the runtime warning QQuickWidget cannot be used as a native child widget. Consider setting Qt::AA_DontCreateNativeWidgetSiblings when clicking on a link in the Welcome page that opens a new browser window, and also fixes the Welcome page getting black in that case.
Details
Details
- Reviewers
mqualmann
Build digikam with QtWebEngine.
Open the Welcome page, click on "documentation" or "digiKam homepage" in "About".
Before, the runtime warning was displayed in the shell and the Welcome page became completely black as soon as the new window opened.
Now neither of both happens.
Diff Detail
Diff Detail
- Repository
- R482 digiKam
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Did you test this king of patch with the geolocation view, in GoogleMaps mode which use also QWebEngine ?
Gilles Caulier
Comment Actions
Note : you patch the digiKam main(). Showfoto main() need also to be patched as it can show the Geolocation view in GoogleMaps mode.
Anyway, if GoogleMaps view work fine with this patch, I don't have any objection to apply it to git/master (with Showfoto patch included of course).
Gilles Caulier
Comment Actions
Yes, that still works fine, but it wasn't affected before either.
Showfoto doesn't show the Welcome page (or does it?), and so the problem this is supposed to fix doesn't occur there (AFAICT).
I just tried to open Help->Online Documentation (which opens a browser window too) while having the GeoLocation view open. No problem whatsoever (with or without the patch).
Comment Actions
I can reproduce the problem, although I always use QWebEngine, I had never noticed it before.
The patch works fine, also with the geolocation.
Maik
Comment Actions
No, welcome page view is not present in Showfoto. Only the geolocation view. So the patch must be applied too to Showfoto::main().
Please update the patch and apply it to git/master.
Gilles Caulier
Comment Actions
In Showfoto the problem may not occur well, but I will try to solve the problem in another way.
Maik
Comment Actions
Yes, but the geolocation view doesn't have that problem, only the welcome page view is affected for some reason.
But ok, I updated the patch to also modify showfoto.
@mqualmann: If you do find a different/better solution, that's fine with me of course.
I'll just leave this differential open for now.
Comment Actions
Close with REVIEW: D17276 was not successful.
remote: https://commits.kde.org/digikam/60721615dd9af2b81dacce06adaa7e31d56eee32
remote: ERROR - Communication problem with Reviewboard. Please contact the KDE sysadmins.
remote: INFO - Please report the following:
remote: INFO - Request URL: https://git.reviewboard.kde.org/api/review-requests/17276/
remote: INFO - Status code: 404
Maik
Comment Actions
"REVIEW: D17276" is for closing a review on reviewboard, with phabricator you need to use something like:
Differential Revision: https://phabricator.kde.org/D17276
I suppose I can abandon this now, then.