Differential D17275

Fixed UI in Color Mix
ClosedPublic
Actions

Authored by varunp on Dec 1 2018, 4:43 AM.

Details

Reviewers
amankumargupta
Group Reviewers
GCompris: Improvements
Maniphest Tasks
T8522: color_mix activities, fix layout.
Summary

Moves + and - logos on paint tubes towards the centre of the screen to make sure they are not cut off in windows.
Fixes T8522

Test Plan

Run on different screen sizes and resolutions to ensure that scaling works well.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
varunp created this revision.Dec 1 2018, 4:43 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptDec 1 2018, 4:43 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
varunp requested review of this revision.Dec 1 2018, 4:43 AM
varunp added a reviewer: jjazeix.
varunp updated this revision to Diff 47083.Dec 8 2018, 12:56 AM

Fixed file permissions and display of text in certain window sizes.

amankumargupta accepted this revision.Dec 9 2018, 7:36 AM
amankumargupta added a subscriber: amankumargupta.

Looks good to me on testing!

This revision is now accepted and ready to land.Dec 9 2018, 7:36 AM
jjazeix closed this revision.Dec 18 2018, 2:56 PM
jjazeix added a subscriber: jjazeix.

Sorry for delay, I fixed other issues within the patch:

  • when you submit an answer, you may have 3 texts displayed on the right that was hidden by the light (too much color/not enough color...)
  • I put the score on the left to avoid potential overriding and having a floating score
  • I set a max value for the circle radius to avoid having it going too big.

Pushed in https://commits.kde.org/gcompris/6801db8c71046c34ea619a6ff7e8b559ee5a99f2
Thank you!

Revision Contents
Changeset List

Diff 47083

View Options

src/activities/color_mix/ColorChooser.qml

Loading...
View Options

src/activities/color_mix/ColorMix.qml

Loading...