Fixed a bug(error?) in ipv4 & ipv6 settings
ClosedPublic

Authored by pranavgade on Nov 30 2018, 2:35 PM.

Details

Summary

Fixed a couple of misplaced lines of code

Diff Detail

Repository
R282 NetworkManagerQt
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pranavgade created this revision.Nov 30 2018, 2:35 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 30 2018, 2:35 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
pranavgade requested review of this revision.Nov 30 2018, 2:35 PM

Thanks for spotting this. I wonder how it's possible this passed the test, I guess comparing it the way we do, it doesn't compare it properly. I'll check the tests further.

jgrulich accepted this revision.Nov 30 2018, 3:06 PM
This revision is now accepted and ready to land.Nov 30 2018, 3:06 PM
This revision was automatically updated to reflect the committed changes.