KateViewInternal: S&R
ClosedPublic

Authored by loh.tar on Nov 30 2018, 2:11 PM.

Details

Summary
  • 'm_view->' => 'view()'
  • 'm_startPos.line()' => 'startLine()'
  • 'm_startX' => 'startX()'
  • 'startPos().line()' => 'startLine()'
  • 'm_startPos' => 'startPos()'

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
loh.tar created this revision.Nov 30 2018, 2:11 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptNov 30 2018, 2:11 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Nov 30 2018, 2:11 PM

Only 'm_view->' => 'view()' has plenty of hits, the others only a few.

Please do a grep for m_startPos. To replace these few would require a changed or added function.

Last note: I hope you test all these changes thoroughly. At the last mentioned m_startPos S&R was suddenly the scrolling broken: Hence undo to only one change.

@cullmann Did you notice this? The other patches did you apply very quick, so I hope I didn't unsettle you with my comments.

cullmann accepted this revision.Dec 5 2018, 4:44 PM

No, I was just busy ;=)
Diff looks ok, will apply.

This revision is now accepted and ready to land.Dec 5 2018, 4:44 PM
This revision was automatically updated to reflect the committed changes.