Fix colors for vector image mimetypes
Changes PlannedPublic

Authored by ndavis on Nov 30 2018, 11:32 AM.


Group Reviewers

The 22px x-office-drawing mimetype icon had a color that was inconsistent with the other icons for that mimetype. I have fixed this and reduced the size of the other icons for the same mimetype. SVG mimetype icons are symlinks to x-office-drawing.svg, so this also fixes those.

Test Plan

Left: before, right: after

Diff Detail

R266 Breeze Icons
fix-svg-mimetype (branched from master)
No Linters Available
No Unit Test Coverage
Build Status
Buildable 5539
Build 5557: arc lint + arc unit
ndavis created this revision.Nov 30 2018, 11:32 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 30 2018, 11:32 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Nov 30 2018, 11:32 AM
ndavis edited the test plan for this revision. (Show Details)Nov 30 2018, 11:34 AM
ndavis edited the summary of this revision. (Show Details)Nov 30 2018, 11:36 AM
ndavis added a comment.EditedNov 30 2018, 11:56 AM

I just ran into 3 other issues.

libreoffice-drawing has the same consistency problem with the same inconsistent color, but at 16px. I noticed that the libreoffice-drawing icons have a color that is the same as or almost the same as the x-office-drawing` icons, which the svg icons are symlinked to. Do we want SVGs and LibreOffice Draw files to have the same color? The blue color on the inconsistent icons is also similar to the blue color used by SVGZ mimetype icons.

ndavis planned changes to this revision.Nov 30 2018, 11:57 AM
ndavis retitled this revision from Fix inconsistent x-office-drawing icon color to Fix colors for vector image mimetypes.
ngraham added a subscriber: ngraham.Dec 1 2018, 3:30 PM

I had never noticed any pattern for the mimetype icons colors. I'd just assumed it was random lol.