Differential D17251

Update Ip-tunnel settings
ClosedPublic
Actions

Authored by pranavgade on Nov 30 2018, 8:57 AM.

Details

Reviewers
jgrulich
Commits
R282:d2531a32e28d: Update Ip-tunnel settings
Summary

Fixed a few things in ip-tunnel settings

Diff Detail

Repository
R282 NetworkManagerQt
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pranavgade created this revision.Nov 30 2018, 8:57 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 30 2018, 8:57 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
pranavgade requested review of this revision.Nov 30 2018, 8:57 AM
jgrulich accepted this revision.Nov 30 2018, 10:27 AM
jgrulich added inline comments.
src/settings/iptunnelsetting.h
28

No need to define this here, it's already defined in iptunnelsetting.cpp.

This revision is now accepted and ready to land.Nov 30 2018, 10:27 AM
Closed by commit R282:d2531a32e28d: Update Ip-tunnel settings (authored by pranavgade, committed by jgrulich). · Explain WhyNov 30 2018, 10:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46540

View Options

src/settings/iptunnelsetting.h

Loading...
View Options

src/settings/iptunnelsetting.cpp

Loading...