do not attempt to link phononexperimental :O
ClosedPublic

Authored by sitter on Nov 29 2018, 12:21 PM.

Details

Summary

${PHONON_LIBS} as the name suggests links all libraries, that includes
the experimental library. it's not even used though.
move to imported target to avoid linking experimental and also get rid
of the include_directories call

Test Plan
➜ DESTDIR=x ninja install &> /dev/null; grep -ri phonon4qt5experimental x
x/usr/lib/x86_64-linux-gnu/cmake/KF5NotifyConfig/KF5NotifyConfigTargets-debug.cmake:  IMPORTED_LINK_DEPENDENT_LIBRARIES_DEBUG "KF5::I18n;KF5::KIOWidgets;Phonon::phonon4qt5;Phonon::phonon4qt5experimental;Qt5::DBus"

with new code

➜ DESTDIR=x ninja install &> /dev/null; grep -ri phonon4qt5experimental x

Diff Detail

Repository
R305 KNotifyConfig
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Nov 29 2018, 12:21 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 29 2018, 12:21 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Nov 29 2018, 12:21 PM
sitter retitled this revision from do not attempt to link phononexperimental :anguished: to do not attempt to link phononexperimental :O.Nov 29 2018, 12:22 PM
sitter edited the test plan for this revision. (Show Details)
apol accepted this revision.Nov 29 2018, 12:23 PM
This revision is now accepted and ready to land.Nov 29 2018, 12:23 PM
This revision was automatically updated to reflect the committed changes.